Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runTools): correct request options type #1073

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(runTools): correct request options type #1073

merged 1 commit into from
Sep 16, 2024

Conversation

granmoe
Copy link
Contributor

@granmoe granmoe commented Sep 13, 2024

See comment here #1064 (comment)

@granmoe granmoe requested a review from a team as a code owner September 13, 2024 18:22
@granmoe granmoe mentioned this pull request Sep 13, 2024
Open
1 task
@granmoe granmoe changed the title feat: Use correct type for runTools options so we can pass maxChatCompletions with no TS error fix: Use correct type for runTools options so we can pass maxChatCompletions with no TS error Sep 13, 2024
@RobertCraigie RobertCraigie changed the title fix: Use correct type for runTools options so we can pass maxChatCompletions with no TS error fix(runTools): correct options type Sep 16, 2024
@RobertCraigie RobertCraigie changed the title fix(runTools): correct options type fix(runTools): correct request options type Sep 16, 2024
@RobertCraigie RobertCraigie force-pushed the mjg/fix-run-tools-runner-options-type branch from df664b4 to 4dccfa2 Compare September 16, 2024 08:19
RobertCraigie
RobertCraigie approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertCraigie RobertCraigie changed the base branch from master to next September 16, 2024 08:21
@RobertCraigie RobertCraigie merged commit 399f971 into openai:next Sep 16, 2024
3 checks passed
@stainless-app stainless-app bot mentioned this pull request Sep 16, 2024
Merged
stainless-app bot pushed a commit that referenced this pull request Sep 16, 2024
@granmoe @stainless-app
fix(runTools): correct request options type (#1073)
5d4d74f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertCraigie RobertCraigie RobertCraigie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@granmoe @RobertCraigie