-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional includes into test/support/test_config.h #1548
Additional includes into test/support/test_config.h #1548
Conversation
15e1636
to
cb340b8
Compare
5f14762
to
2871802
Compare
Signed-off-by: Sergey Kopienko <[email protected]>
…s not required anymore Signed-off-by: Sergey Kopienko <[email protected]>
…s not required anymore Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
2871802
to
e862fd3
Compare
Signed-off-by: Sergey Kopienko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
I think before merging (especially for inclusion with 2022.6.0), we should:
- Create an issue to add testing for include order which includes oneDPL headers before stdlib headers, since this changes all of our tests to include a stdlib header first ,as discussed offline.
- Get approval from another person.
- Run a full nightly CI with this branch to see the effect of the changes in
common_config.h
(that there are no unforeseen consequences) I believe that this is merely applying the same treatment for the missing TBB headers as we do for the mismatched tbb install above, so I think it should be OK.
UPD: the issue created: #1564
Discussed offline, with another approval, it seems reasonable to merge and check nightly CI due to contention on runners rather than generating an extra full run. We just need to follow up to confirm we haven't caused trouble after the next run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR we have 3 big changes:
test/support/test_config.h
we add inclusion of some files from standard library to have correct definitions of used defines:test/support/test_config.h
at first place.No additional includes required anymore if they are really not required for the test: example1, example2
include/oneapi/dpl/internal/common_config.h
: see changes.Also this fix resolves a lot of errors in the tests compiled with
g++
compiler.Also we have the alternative approach at #1555