Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package update] Autogenerated conf-libclang packages for LLVM upto 18.0 #25889

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thierry-martinez
Copy link
Contributor

@thierry-martinez thierry-martinez commented May 16, 2024

This merge request makes conf-libclang.N packages autogenerated so that each package ensures that a Clang library version N or below is installed. EDIT: The configure scripts are now written in OCaml, for instance: https://github.com/ocaml/opam-repository/blob/4f286db2006c405a0f54f789422cb3fca35daa49/packages/conf-libclang/conf-libclang.18/files/configure.ml (the OCaml modules are identical from one conf-libclang version to another).

The generator is here: https://github.com/thierry-martinez/conf-libclang/blob/main/generate.sh EDIT: https://github.com/thierry-martinez/conf-libclang/blob/main/generate.ml

@mseri
Copy link
Member

mseri commented May 17, 2024

@kit-ty-kate sorry to bother, but you had a lot of experience with llvm/clang packages. Could you by chance have a look?

@kit-ty-kate
Copy link
Member

looks fine to me

@thierry-martinez thierry-martinez marked this pull request as draft May 17, 2024 13:01
@thierry-martinez
Copy link
Contributor Author

All my apologies: there still are a lot of CI errors, I will ping you when I fixed most of them!

@thierry-martinez thierry-martinez marked this pull request as ready for review May 23, 2024 15:03
@@ -44,13 +44,13 @@ x-ci-accept-failures: [
"fedora-38" "fedora-39" "fedora-40" # clang-devel is not available
"oraclelinux-9" # clang-devel is not available
]
extra-source "configure.sh": {
extra-source "configure.sh" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extra-source "configure.sh" {
extra-source "configure.ml" {

@rmonat
Copy link
Contributor

rmonat commented Jun 6, 2024

It's funny, it seems the x-ci-accept-failures here is not taken into account in the CI report, for Fedora 39?

Copy link
Contributor

@rmonat rmonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions below related to fedora. Thank you for all the work @thierry-martinez!

["libclang-11-dev" "libclang-cpp11-dev" "llvm-11-dev"] { os-distribution = "debian" & os-version = "10" }
["clang-devel-12.0.1" "llvm-devel-12.0.1" "llvm-static-12.0.1" "zlib-devel"]
{os-distribution = "ol" & os-version >= 8 & os-version < 9}
["clang12-devel" "llvm12-devel" "llvm12-static" "zlib-devel" "redhat-rpm-config"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["clang12-devel" "llvm12-devel" "llvm12-static" "zlib-devel" "redhat-rpm-config"]
["clang11-devel" "llvm11-devel" "llvm11-static" "zlib-devel" "redhat-rpm-config"]

Maybe that could be sufficient to fix fedora 39?

["libclang-13-dev" "libclang-cpp13-dev" "llvm-13-dev"] { os-distribution = "debian" & os-version = "10" }
["clang-devel-14.0.6" "llvm-devel-14.0.6" "llvm-static-14.0.6" "zlib-devel"]
{os-distribution = "ol" & os-version >= 8}
["clang14-devel" "llvm14-devel" "llvm14-static" "zlib-devel" "redhat-rpm-config"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fedora 40, I would suggest

  ["clang13-devel" "llvm13-devel" "llvm14-static" "zlib-devel" "redhat-rpm-config"]

@rmonat
Copy link
Contributor

rmonat commented Jun 27, 2024

@thierry-martinez I was wondering if you want to merge this as-is or...?

@shonfeder
Copy link
Collaborator

Hi, @thierry-martinez! Just checking in here on your availability for landing this update. Please let us me know if there's support you need from the maintainer side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants