Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome #2701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Biome #2701

wants to merge 1 commit into from

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Sep 13, 2024

This PR introduces Biome to CI. This allows you to perform format and lint checks on several file types. Actually, it found some issues.

https://biomejs.dev

Remember to use hide white space mode to make the review easier.

Signed-off-by: Sora Morimoto <[email protected]>
@cuihtlauac
Copy link
Collaborator

cuihtlauac commented Sep 16, 2024

Thanks @smorimoto. This is interesting; however, I have mixed feelings about it.

I'm a strong supporter of automated checks. However, the proposed changes only include whitespace, line breaks, and optional semicolumns. Did I miss something? Tidying this way is acceptable, but having a tool to do that feels overkill. Do those files change often enough to use an automated tool?

Additionally, if we were to use such a tool, we should be able to run it locally, like we do with ocamlformat. However, if I'm correct, that would add Node.js to our list of development dependencies. Isn't it a lot for that kind of change?

@smorimoto
Copy link
Member Author

Biome does not require the Node.js ecosystem: https://biomejs.dev/guides/manual-installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants