UI: Enable first-party YouTube Chat features in OBS #10770
+85
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
reviewed
Jun 3, 2024
msuman-google
force-pushed
the
youtube-live-chat
branch
6 times, most recently
from
f228eec
to
9062c82
Compare
msuman-google
force-pushed
the
youtube-live-chat
branch
from
9062c82
to
380a81d
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
msuman-google
force-pushed
the
youtube-live-chat
branch
from
380a81d
to
22e3abc
Compare
msuman-google
force-pushed
the
youtube-live-chat
branch
4 times, most recently
from
0419691
to
a36be2f
Compare
msuman-google
force-pushed
the
youtube-live-chat
branch
2 times, most recently
from
1093651
to
4bc6567
Compare
PatTheMav
requested changes
Jul 24, 2024
msuman-google
force-pushed
the
youtube-live-chat
branch
from
4bc6567
to
e73e872
Compare
msuman-google
force-pushed
the
youtube-live-chat
branch
2 times, most recently
from
ffd1d2d
to
c949d00
Compare
msuman-google
force-pushed
the
youtube-live-chat
branch
from
c949d00
to
25162a5
Compare
gxalpha
requested changes
Aug 26, 2024
msuman-google
force-pushed
the
youtube-live-chat
branch
3 times, most recently
from
d07b5dd
to
da5b7e4
Compare
PatTheMav
reviewed
Sep 17, 2024
msuman-google
force-pushed
the
youtube-live-chat
branch
from
da5b7e4
to
a299932
Compare
PatTheMav
approved these changes
Sep 18, 2024
Use the cookie manager shared by service integration browser docks for YouTube Control Panel. This will enable users of the YouTube Chat panel have a better (creator facing) experience for observed chat message latency, for those users who sign-in to the YouTube Control Panel or YouTube Live Chat. NOTE: This commit does not have any migration logic for existing logged-in users of YTCP, they will need to sign-in again. Based on usage stats, this is not going to affect a large fraction of OBS users.
Unlock the full feature set of the YouTube Chat dock in OBS by removing custom scripting/CSS logic. Enable the signed-in experience for live streaming content creators (sharing login credentials with the YouTube Control panel dock, see obsproject#10747). This will allow OBS users to utilize features _already_ supported in the YouTube Chat plugin, such as * creating polls * managing Q&A sessions * a rich emoji set in the input panel * emoji fountains * moderation tools and many more. These features are available to users who are logged-in to YouTube Chat and/or the YouTube Control panel.
msuman-google
force-pushed
the
youtube-live-chat
branch
from
4b74759
to
9dbf67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unlock the full feature set of the YouTube Chat dock in OBS by removing custom scripting/CSS logic. Enable the signed-in experience for live streaming content creators (sharing login credentials with the YouTube Control panel dock, see
#10747).
Motivation and Context
This will allow OBS users to utilize features already supported in the YouTube Chat plugin, such as
and many more. These features are available to users who are logged-in to YouTube Chat and/or the YouTube Control panel.
How Has This Been Tested?
Built OBS locally on Linux workstation, verified existing functionality for YouTube Chat continues to work in signed-out state. Signing-in to YouTube hides the native Qt input panel in favour of the YouTube native input panel that unlocks all of the first-party functionality for live streaming content creators.
Types of changes
@ not working in youtube dock #9506
YouTube chat input box covers chat #7353
Checklist: