UI: Add support for additional canvases to multitrack video output #10635
Conversation
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
2 times, most recently
from
ce1b263
to
c03b4fb
Compare
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
2 times, most recently
from
6dcd68c
to
d404b1b
Compare
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
2 times, most recently
from
420b8d7
to
60f2951
Compare
|
#10633 was merged some time ago. This will need to be rebased and get CI to pass. |
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
from
60f2951
to
7c05363
Compare
|
@palana It looks like the build failures are still present. |
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
from
7c05363
to
8dffc0a
Compare
| @@ -11053,6 +11053,33 @@ QColor OBSBasic::GetSelectionColor() const | |||
| } | |||
| } | |||
|
|
|||
| const std::vector<MultitrackVideoViewInfo> & | |||
| OBSBasic::GetAdditionalMultitrackVideoViews() | |||
There was a problem hiding this comment.
This does nothing but return a copy of the value. Probably fine to fetch the value directly?
There was a problem hiding this comment.
not sure I follow, this returns a const reference, rather than a copy (i.e. you're allowed to read entries, but not modify them)
There was a problem hiding this comment.
@tt2468 Could you clarify the concern here?
| blog(LOG_WARNING, | ||
| "Failed to get obs_video_info while creating encoder %zu", | ||
| encoder_index); | ||
| throw MultitrackVideoError::warning( | ||
| QTStr("FailedToStartStream.FailedToGetOBSVideoInfo") | ||
| .arg(name_buffer->array, encoder_type)); | ||
| } | ||
| obs_video_info *ovi = &ovi_storage; | ||
|
|
||
| const char *view_name = nullptr; |
There was a problem hiding this comment.
This is probably safer as std::string.
There was a problem hiding this comment.
safer in what way? encoder_config can't be modified in here (unless someone adds a const cast?), so the pointer (once assigned) stays valid for this scope at least (and it's not used outside of this scope)
There was a problem hiding this comment.
@tt2468 Could you clarify the concern here?
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
from
3d41885
to
dabc2f6
Compare
Co-authored-by: Ruwen Hahn <[email protected]>
…nregister rename `void*` argument
…nregister add prefix to callback types
…nregister add name parameter to callbacks
add name parameter to callbacks
…nregister Update documentation to reflect latest code changes.
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
from
dabc2f6
to
212f177
Compare
Description
Adds frontend API calls to allow plugins to register additional canvases/video outputs that will participate in multitrack video configuration generation and multitrack video streams
Motivation and Context
Currently additional views/canvases have to use separate rtmp connections or similar to be streamed, where the multitrack video output allows both multiple renditions of the same view and also different views to be streamed
How Has This Been Tested?
Twitch Enhanced Broadcasting beta
Types of changes
Checklist: