Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: encode reserved characters in URI path #1268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riddla
Copy link

@riddla riddla commented Mar 1, 2024

I fell into a rabbit hole yesterday analysing why Slack would not show the preview of an og:image. After a long try and error I discovered that the URIs generated via the ipx provider contains ampersands respectively: the Slackbot needs URIs with encoded reserved characters in the URIs path .

With encoded characters (fit_inside%26f_png%26s_1200x630) the preview came to life.

@danielroe danielroe requested a review from pi0 April 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant