Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: generate middleware types" #824

Closed
wants to merge 1 commit into from

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jun 22, 2023

πŸ”— Linked issue

Reverts #796

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When adding named middleware with addRouteMiddleware, the type is not generated, so revert it once.
(Even without this feature, I have no trouble migrating Nuxt 3.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx requested a review from danielroe June 22, 2023 01:48
@danielroe
Copy link
Member

I think it is expected that middleware added at runtime wouldn't have types generated for them. (True also in Nuxt 3.)

@wattanx
Copy link
Collaborator Author

wattanx commented Jun 23, 2023

True, the type was not generated even in Nuxt 3.
I guess I was mistaken. Thanks!!

@wattanx wattanx closed this Jun 23, 2023
@danielroe danielroe deleted the revert-796-feat-middleware-types branch June 23, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants