Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nrk-edit icon #220

Merged
merged 1 commit into from
Jun 21, 2023
Merged

feat: add nrk-edit icon #220

merged 1 commit into from
Jun 21, 2023

Conversation

skjalgepalg
Copy link
Collaborator

Added nrk-edit icon

  • optimized through svgomg
  • removed explicit height and width
  • replaced fill with currentColor

resolves #217

Reviewers:

  • Ref Add duotone variants #218 should this icon have a duotone identifier in the name? e.g. nrk-edit-dutone?
    • And if so do we have a non-duotone icon we should add as well?

@skjalgepalg skjalgepalg added enhancement semver:minor Involves added, backwards compatible, functionality labels Jun 20, 2023
@skjalgepalg skjalgepalg self-assigned this Jun 20, 2023
@skjalgepalg skjalgepalg merged commit 599260e into master Jun 21, 2023
1 check passed
@skjalgepalg skjalgepalg deleted the edit-icon branch June 21, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nottemi nottemi nottemi approved these changes

@asmundmatzow asmundmatzow Awaiting requested review from asmundmatzow

@stefanogden stefanogden Awaiting requested review from stefanogden

Assignees

@skjalgepalg skjalgepalg

Labels
enhancement semver:minor Involves added, backwards compatible, functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New icon: nrk-edit
2 participants
@skjalgepalg @nottemi