Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: do not interpret "main" as a URL #55003

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 19, 2024

As documented, its value is a path.

node/doc/api/packages.md

Lines 1210 to 1211 in c42d846

The `"main"` field defines the entry point of a package when imported by name
via a `node_modules` lookup. Its value is a path.

As documented, its value is a path.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (c42d846) to head (f0c3a2c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55003   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         652      652           
  Lines      183759   183744   -15     
  Branches    35861    35853    -8     
=======================================
- Hits       161770   161766    -4     
+ Misses      15239    15229   -10     
+ Partials     6750     6749    -1     
Files with missing lines Coverage Δ
lib/internal/modules/esm/resolve.js 96.62% <100.00%> (-0.01%) ⬇️
src/node_file.cc 77.36% <100.00%> (+0.26%) ⬆️

... and 31 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants