Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: move complete to its own file #54989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

This PR moves a large function from repl.js into it's own file, internal/repl/complete.js. This is an attempt to slowly declutter the file.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 97.90476% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (7014e50) to head (5a62c67).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/repl/complete.js 97.70% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54989      +/-   ##
==========================================
+ Coverage   88.06%   88.08%   +0.01%     
==========================================
  Files         652      653       +1     
  Lines      183545   183705     +160     
  Branches    35854    35853       -1     
==========================================
+ Hits       161648   161818     +170     
+ Misses      15146    15139       -7     
+ Partials     6751     6748       -3     
Files with missing lines Coverage Δ
lib/internal/repl/utils.js 95.92% <100.00%> (+0.18%) ⬆️
lib/repl.js 93.97% <100.00%> (-0.90%) ⬇️
lib/internal/repl/complete.js 97.70% <97.70%> (ø)

... and 28 files with indirect coverage changes

@RedYetiDev
Copy link
Member Author

@nodejs/repl

@anonrig
Copy link
Member

anonrig commented Sep 18, 2024

Moving these to new files will have an impact on node.js startup time.

@RedYetiDev
Copy link
Member Author

Moving these to new files will have an impact on node.js startup time.

How much of an impact? It is negligible?

@aduh95
Copy link
Contributor

aduh95 commented Sep 19, 2024

Moving these to new files will have an impact on node.js startup time.

Why would that be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants