Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: float VS 17.11 compilation patch #54970

Merged
merged 1 commit into from
Sep 19, 2024
Merged

build,win: float VS 17.11 compilation patch #54970

merged 1 commit into from
Sep 19, 2024

Conversation

StefanStojanovic
Copy link
Contributor

Floats dependency patch from ngtcp2/nghttp3#252 to enable updating VS to the latest version (17.11) in the CI.

Fixes: #54898

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 16, 2024
@StefanStojanovic StefanStojanovic added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. and removed needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 16, 2024
@RedYetiDev RedYetiDev added the dependencies Pull requests that update a dependency file. label Sep 16, 2024
@anonrig anonrig added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig
Copy link
Member

anonrig commented Sep 16, 2024

cc @nodejs/build @nodejs/platform-windows

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62484/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 653b965 into nodejs:main Sep 19, 2024
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 653b965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARM64 compilation broken on VS 2022 17.11
7 participants
@StefanStojanovic @nodejs-github-bot @anonrig @lpinca @targos @richardlau @RedYetiDev