string_decoder: refactor encoding validation

[anonrig]

As far as I can tell, I couldn't find a valid reason to call normalizeEncoding and isEncoding for the same input. Normalize encoding function returns undefined if the encoding is not valid.

Benchmark ci: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1640/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (291d90a) to head (bf54e83).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54957      +/-   ##
==========================================
- Coverage   88.04%   88.03%   -0.01%     
==========================================
  Files         652      652              
  Lines      183764   183747      -17     
  Branches    35862    35861       -1     
==========================================
- Hits       161787   161756      -31     
- Misses      15233    15239       +6     
- Partials     6744     6752       +8     

Files with missing lines	Coverage Δ
lib/internal/util.js	96.54% <100.00%> (-0.10%)	⬇️
lib/string_decoder.js	100.00% <100.00%> (+1.80%)	⬆️

... and 19 files with indirect coverage changes

[anonrig]

Is this a semver-major? @nodejs/tsc

[RedYetiDev]

Is this a semver-major? @nodejs/tsc

Why would it be? Isn't it throwing the same errors for the same functions, just in different spots internally?

Edit: Oh I guess cause the monkey-patching

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62467/

[ronag]

I think this might be semver-major due to the monkey patching comment.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62568/