Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svg-generator): add kebab-case transform to type generator (#143) #144

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

mokipedia
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

icons with _ in name generate a missmatch between key and type, as keys are converted to kebab-case

Issue Number: #143

What is the new behavior?

as discussed in #143: types are now also generated as kebab-case

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Copy link

stackblitz bot commented Dec 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal
Copy link
Member

@mokipedia tests are failing in CI

@mokipedia
Copy link
Contributor Author

tests should be green now, my bad.

@NetanelBasal NetanelBasal merged commit d4b688e into ngneat:master Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants