Skip to content

Commit

Permalink
fix(EventEmitter): Update rxjs dependency. Add 'emit' method.
Browse files Browse the repository at this point in the history
fixes #122

BREAKING CHANGE:

Before:
```js
@output() foo = new EventEmitter();

foo.next();
```

Before:
```js
@output() foo = new EventEmitter();

foo.emit(); // <--
```
  • Loading branch information
timkindberg committed Jan 12, 2016
1 parent 383ed2d commit d500158
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/events/event-emitter.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Subject from '@reactivex/rxjs/dist/es6/Subject';
import Subject from 'rxjs/Subject';

This comment has been minimized.

Copy link
@MikeRyanDev

MikeRyanDev Jan 19, 2016

Member

I think this should be import {Subject} from 'rxjs/Subject';


/**
* Use by directives and components to emit custom Events. Copied from Angular 2's [EventEmitter](
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
],
"license": "ISC",
"dependencies": {
"@reactivex/rxjs": "5.0.0-alpha.7",
"rxjs": "5.0.0-beta.0",
"reflect-metadata": "^0.1.2"
},
"devDependencies": {
Expand Down

0 comments on commit d500158

Please sign in to comment.