仕様変更等 #43
Merged
仕様変更等 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: env.exampleにWebhook URLを追加
userがfirebaseに存在して，DBに存在しない場合，signinをpassしないように修正
Change pairing process
fix: signupの検証を少し厳しく
fix: majorとminorを文字列として返すよう修正
hyouhyan
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
確認事項
マージ先，マージ元のブランチは正しいですか？
mainに直接マージしようとしていませんか？
コミット，ファイルで変更点を確認しましたか？
Privateな情報が入っていないですか？
実装内容(変更点)
具体的な変更点や修正箇所を箇条書きでリストアップしてください。