-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mTLS #39
feat: add mTLS #39
Conversation
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Cool!
I think we can do this step by step. If someone requests it, it won't be a hassle to add it. But also some short explanation in README.md might help.
I think using a semantic pin where possible and keep the dependencies updated is a good mix to satisfy most consumers. |
I've added the 2 new flags in the documentation with some lines about https validation. |
You can either squash the "fix: black" commit into the "feat: add mTLS" commit, or I can squash the whole PR. WDYT? |
I can but on github you can "Squash and merge" to only have one commit and you can override the commit message here to fit repository best practice. |
Thank you! |
This PR adds the possibility to connect to a control agent with mTLS enabled (
cert-required
). I've also added a missing dependency.I haven't included the option to pass a custom certificate authority since you can use the
REQUESTS_CA_BUNDLE
environment variable for that purpose. However, I can add it if you think it's not sufficient.PS: I've pinned the requests dependency using
~=
to prevent installation issues in case of a major release. What are your thoughts on using this approach for all dependencies ?