Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent background, cursor_column background and selection background options #287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Dave-Elec
Copy link

Added transparent background which can be set by

let g:gruvbox_transparent_bg=1

Added cursor_column background option which can be set by

let g:gruvbox_cursor_column=<color_name>

Added selection background option which can be set by

let g:gruvbox_selection_bg=<color_name>

@bavarianbidi
Copy link

@morhetz could you please take a look?

i'm using this branch a while to get the transparent background and from my point of view, it looks good!
thank you @Dave-Elec

@areisrosa
Copy link

Working perfectly for me now!
Thanks @Dave-Elec

@Dave-Elec
Copy link
Author

Thanks, Glad it helped.

@funnydman
Copy link

So, are you going to merge it?

@HawkinsT
Copy link

HawkinsT commented May 4, 2020

This is a great idea, although unfortunately this fails for me in both nvim-qt and gvim in windows (background becomes a solid colour dictated by background value).

@polyzen
Copy link

polyzen commented May 4, 2020

You may want to submit this PR to https://github.com/gruvbox-community/gruvbox

@vnpavanelli
Copy link

Thanks, @Dave-Elec ! This worked for me in nvim.
Using nvim-gtk or gnvim both this and the command on #96 don't work.

@saragiotto
Copy link

saragiotto commented Jun 22, 2020

When this background is activated, some color's change on airline/tabline.

Screen Shot 2020-06-22 at 11 32 13

Screen Shot 2020-06-22 at 11 35 29

@Dave-Elec
Copy link
Author

Dave-Elec commented Jun 23, 2020

@saragiotto Try putting colorscheme gruvbox after gruvbox settings.

Sorry, I don't use gruvbox anymore (currently using gruvbox-material) so I can't test it.

@kalkayan
Copy link

kalkayan commented May 17, 2021

I also had the same issue with g:gruvbox_transparent_bg this works fine in Mac's terminal (first screenshot) but creates problems in item (second screenshot)

Screenshot 2021-05-17 at 5 48 59 PM

Screenshot 2021-05-17 at 5 51 32 PM

I answered this on stack over flow - https://stackoverflow.com/a/67569365/14526555. copy-pasting from there.

    " Workaround for creating transparent bg
    autocmd SourcePost * highlight Normal     ctermbg=NONE guibg=NONE
            \ |    highlight LineNr     ctermbg=NONE guibg=NONE
            \ |    highlight SignColumn ctermbg=NONE guibg=NONE

People on internet has similar thing with VimEnter instead of SourcePost. VimEnter solves this problem partially and creates prblem when we source again (therefore SourcePost)

Final Results on iterm

Screenshot 2021-05-17 at 5 56 02 PM

see this - https://github.com/kalkayan/dotfiles for more info.

@clint911
Copy link

Totally worked for making gruvbox transparent
" Workaround for creating transparent bg
autocmd SourcePost * highlight Normal ctermbg=NONE guibg=NONE
\ | highlight LineNr ctermbg=NONE guibg=NONE
\ | highlight SignColumn ctermbg=NONE guibg=NONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants