RUST-1994 Implement happy eyeballs for TCP connection #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
changes LGTM! maybe hold off on merging til we get some feedback in #1170
| let (mut left, mut right) = (left.into_iter(), right.into_iter()); | ||
| while let Some(a) = left.next() { | ||
| out.push(a); | ||
| std::mem::swap(&mut left, &mut right); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1994
This adapts the implementation from the
happy-eyeballscrate rather than using it directly to preserve some stream initialization that didn't fit in that crate and better match our error handling.Benchmarks are within noise:
TEST: Run Command (cold start) -- Score: 0.197 MB/s, Median Iteration Time: 0.659sTEST: Run Command (cold start) -- Score: 0.189 MB/s, Median Iteration Time: 0.686sThe implementation here is a fairly minimal rendition of RFC 6555; it does not include: