chore: set type to commonjs in config-loader package.json #2794
Conversation
🦋 Changeset detectedLatest commit: a04ff38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
web-padawan
force-pushed
the
test/config-loader-no-detect-module
branch
from
7b88d4d
to
dc346ee
Compare
packages/config-loader/package.json
Outdated
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "build": "tsc", | |||
| "test:node": "mocha test/**/*.test.js --reporter dot", | |||
| "test:node": "mocha test/**/*.test.js --reporter dot --no-experimental-detect-module", | |||
There was a problem hiding this comment.
Is this roughly the same as adding a "type": "commonjs" entry?
There was a problem hiding this comment.
Yes, adding "type": "commonjs" works too. I can add it if you think it's a better solution.
There was a problem hiding this comment.
I'm not 100% sure where this package fits in the ecosystem, but doing so would prevent any consumers from having a similar issue, right?
There was a problem hiding this comment.
@Westbrook The package is used by @web/dev-server and @web/test-runner to load respective configs.
Updated to use "type": "commonjs" and added a changeset. I think it's fine to use patch release for this.
web-padawan
changed the title
What I did
Fixes #2793
Set
typetocommonjsto avoid test failure due to Node 22.7 experimental module syntax detection.