Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add _site-dev and _merged_assets to .eslintignore #2790

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

web-padawan
Copy link
Contributor

What I did

Added _side-dev and docs/_merged_assets folders to .eslintignore to fix warnings I'm getting locally:

> lint:eslint
> eslint --ext .ts,.js,.mjs,.cjs .


/Users/serhii/cf/modernweb/_site-dev/guides/going-buildless/css/__mdjs-stories.js
  43:2  error  Unnecessary semicolon  @typescript-eslint/no-extra-semi
> lint:prettier
> node node_modules/prettier/bin-prettier.js "**/*.{ts,js,mjs,cjs,md}" --check --ignore-path .eslintignore

Checking formatting...
[warn] docs/_merged_data/site.cjs
[warn] Code style issues found in the above file. Forgot to run Prettier?

Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: 8a5a8c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@web-padawan
Copy link
Contributor Author

Test failures are unrelated to this PR so I'll merge it.

@web-padawan web-padawan merged commit 04517c6 into master Aug 29, 2024
5 of 7 checks passed
@web-padawan web-padawan deleted the chore/update-eslintignore branch August 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant