chore: reenable all tests and update snapshots #2370

daKmoR · 2023-07-07T14:51:43Z

What I did

changeset-bot · 2023-07-07T14:51:47Z

⚠️ No Changeset found

Latest commit: 4c331b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/rollup-plugin-polyfills-loader/test/snapshots/flattened.html

thepassle · 2023-07-09T06:21:14Z

This PR seems to mostly fix the failing tests on master, but now the tests that were supposed to be fixed by #2366 (by @tmsns ) are broken again, seemingly without any apparent reason. @tmsns would you mind taking a look at this?

koddsson · 2023-07-10T06:49:28Z

If we don't come up with a quick solution to this, we can look into disabling these tests again temporarily in order to get all the tests running again on master.

tmsns · 2023-07-10T13:23:44Z

@thepassle here is a proposal to fix the "random" timeouts. Locally it works. Let's see if it works correctly in a pipeline.

koddsson · 2023-07-10T13:40:59Z

@daKmoR; wanna pull master into this branch after we merged #2371? That might have fixed the failing tests 😄

daKmoR · 2023-07-10T15:43:34Z

packages/rollup-plugin-polyfills-loader/test/snapshots/flattened.html

      return loadScript('./entrypoint-b.js', 'module', []);
+    }, function () {
+      return loadScript('./entrypoint-a.js', 'module', []);


hmmm I'm just wondering is the order here maybe wrong?

as it's now entrypoint-b and then entrypoint-a 🤔

I dont think the order matters here?

koddsson · 2023-07-10T20:20:49Z

This is looking green except for the windows tests hanging, which I believe is a separate issue.

tmsns · 2023-07-10T20:30:08Z

Took a first look at the Windows pipeline. Seemed to be hanging once wireit starts the tsc —build —pretty command in the new mocks project. Not sure whether wireit can’t start it or typescript can’t complete it.

koddsson

This looks pretty good to me! I'm not sure on the snapshot tests but I'm not sure if the order matters.

koddsson · 2023-07-11T07:20:41Z

.github/workflows/verify-windows.yml

@@ -4,6 +4,7 @@ on: pull_request

 jobs:
  verify-windows:
+    timeout-minutes: 30


I like that we have a timeout now. I'd argue that we can probably make it even lower but maybe in a future PR.

thepassle · 2023-07-11T07:29:32Z

So is this an issue with wireit? It seems unlikely that its an issue with TSC, right? Should we disable wireit for now, and just run TSC directly? What do you think @daKmoR ?

thepassle · 2023-07-11T14:42:55Z

Not really sure why, but I'm still seeing wireit running in the pipeline, so it's still hanging on Verify Windows

tmsns · 2023-07-11T17:50:08Z

@web/mocks itself is also using wireit 🙈. It’s not only on top level.

web/packages/mocks/package.json

Line 41 in 6544b78

"types": "wireit",

koddsson · 2023-07-11T19:33:21Z

Now this is happening without wireit! 🤔

Run npm run build
  npm run build
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    WIREIT_CACHE: github
    ACTIONS_CACHE_URL: https://artifactcache.actions.githubusercontent.com/ccnqSCum0KFcxsiFoFI7NcNXpjM[3](https://github.com/modernweb-dev/web/actions/runs/5523695137/jobs/10074963603?pr=2370#step:8:3)eDUNQ90mJ1DwqHCbmkBIOA/
    ACTIONS_RUNTIME_TOKEN: ***

> build
> rimraf --glob packages/*/tsconfig.tsbuildinfo && tsc --build && npm run types


> types
> cd packages/mocks && npm run types


> @web/[email protected] types
> tsc --build --pretty

Terminate batch job (Y/N)? 
Error: The operation was canceled.

koddsson · 2023-07-11T19:41:46Z

Maybe we can enable the diagnostics flag to get a better idea of what's going on?

I googled around and someone talked about this happening on machines with lower memory and I did discover that the Windows machines have 7GB memory while macOS has 14GB which might explain why it would only hang on Windows machines.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

daKmoR · 2023-07-11T21:26:22Z

ok, I now specifically NOT do the types action on windows (there is no need to do it anyways)

still there is one failing test... but I will leave this for another PR

thepassle reviewed Jul 9, 2023

View reviewed changes

packages/rollup-plugin-polyfills-loader/test/snapshots/flattened.html Outdated Show resolved Hide resolved

daKmoR force-pushed the chore/renableTests branch from 997dfc5 to 04e0bd7 Compare July 10, 2023 15:41

daKmoR commented Jul 10, 2023

View reviewed changes

daKmoR force-pushed the chore/renableTests branch from 04e0bd7 to 3ef40f8 Compare July 11, 2023 06:07

chore: reenable all tests and update snapshots

c5ba1d3

daKmoR force-pushed the chore/renableTests branch from 3ef40f8 to c5ba1d3 Compare July 11, 2023 06:11

koddsson approved these changes Jul 11, 2023

View reviewed changes

daKmoR force-pushed the chore/renableTests branch from 19b5d00 to 6544b78 Compare July 11, 2023 12:54

daKmoR force-pushed the chore/renableTests branch from 6544b78 to f0eae22 Compare July 11, 2023 18:41

chore: do not run types on windows

4c331b2

daKmoR force-pushed the chore/renableTests branch from f0eae22 to 4c331b2 Compare July 11, 2023 20:59

daKmoR merged commit dd5e0e5 into master Jul 11, 2023
4 of 5 checks passed

daKmoR deleted the chore/renableTests branch July 11, 2023 21:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: reenable all tests and update snapshots #2370

chore: reenable all tests and update snapshots #2370

daKmoR commented Jul 7, 2023

changeset-bot bot commented Jul 7, 2023 •

edited

Loading

thepassle commented Jul 9, 2023

koddsson commented Jul 10, 2023

tmsns commented Jul 10, 2023

koddsson commented Jul 10, 2023

daKmoR Jul 10, 2023

thepassle Jul 10, 2023

koddsson commented Jul 10, 2023

tmsns commented Jul 10, 2023

koddsson left a comment

koddsson Jul 11, 2023

thepassle commented Jul 11, 2023

thepassle commented Jul 11, 2023

tmsns commented Jul 11, 2023

koddsson commented Jul 11, 2023 •

edited

Loading

koddsson commented Jul 11, 2023

daKmoR commented Jul 11, 2023

chore: reenable all tests and update snapshots #2370

chore: reenable all tests and update snapshots #2370

Conversation

daKmoR commented Jul 7, 2023

What I did

changeset-bot bot commented Jul 7, 2023 • edited Loading

⚠️ No Changeset found

thepassle commented Jul 9, 2023

koddsson commented Jul 10, 2023

tmsns commented Jul 10, 2023

koddsson commented Jul 10, 2023

daKmoR Jul 10, 2023

Choose a reason for hiding this comment

thepassle Jul 10, 2023

Choose a reason for hiding this comment

koddsson commented Jul 10, 2023

tmsns commented Jul 10, 2023

koddsson left a comment

Choose a reason for hiding this comment

koddsson Jul 11, 2023

Choose a reason for hiding this comment

thepassle commented Jul 11, 2023

thepassle commented Jul 11, 2023

tmsns commented Jul 11, 2023

koddsson commented Jul 11, 2023 • edited Loading

koddsson commented Jul 11, 2023

daKmoR commented Jul 11, 2023

changeset-bot bot commented Jul 7, 2023 •

edited

Loading

koddsson commented Jul 11, 2023 •

edited

Loading