Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBB bug Fix #9688

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

OpenBB bug Fix #9688

wants to merge 11 commits into from

Conversation

parthiv11
Copy link
Contributor

@parthiv11 parthiv11 commented Sep 3, 2024

Description

Please include a summary of the change and the issue it solves.

Fixes #9045

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@parthiv11
Copy link
Contributor Author

parthiv11 commented Sep 3, 2024

@martyna-mindsdb please check this update, it should work .

Readme mentioned about openbb_fetcher table which is not now supported, should i add that or remove it from readme as well

@parthiv11 parthiv11 changed the title OpenB bug API KEY Fix OpenBB bug API KEY Fix Sep 3, 2024
@parthiv11
Copy link
Contributor Author

parthiv11 commented Sep 6, 2024

@ZoranPandovski

Readme mentioned about openbb_fetcher table which is not now supported, should i add that or remove it from readme as well

@martyna-mindsdb
Copy link
Contributor

@parthiv11
If something is not supported yet, but will be supported in future, you can create a To do section and add it there.

I get the same error still:

  • I added relevant API keys to my OpenBB Hub,
  • I regenerated my PAT,
  • After connecting to MindsDB, querying tables results in missing api key error.

@ZoranPandovski Does it work for you?

@parthiv11
Copy link
Contributor Author

@martyna-mindsdb now it will work 100%.

please check it out

@martyna-mindsdb
Copy link
Contributor

@parthiv11
I have switched to this PR branch and tested it. But I still get the same error.

Screen.Recording.2024-09-13.at.13.02.32.mov

@parthiv11
Copy link
Contributor Author

parthiv11 commented Sep 13, 2024

@martyna-mindsdb have you updated requirements.txt ?

@martyna-mindsdb
Copy link
Contributor

Thanks @parthiv11 - I upgraded the versions of the dependencies and it works now.

@parthiv11
Copy link
Contributor Author

parthiv11 commented Sep 13, 2024

Yessss....

let me know, what else need to update

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthiv11
Copy link
Contributor Author

@ZoranPandovski done

@parthiv11 parthiv11 changed the title OpenBB bug API KEY Fix OpenBB bug Fix Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Updates to OpenBB APIs to be investigated
3 participants