Fix CUDA reduction ops handling of optional axes input #22149
Merged
+45
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianleiwu
previously approved these changes
Sep 19, 2024
Add test to validate correct handling with missing axes input and noop_with_empty_axes
tianleiwu
approved these changes
Sep 20, 2024
skottmckay
deleted the
skottmckay/FixCudaReductionOpsHandlingOfOptionalAxesInput
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The optional
axesinput may exist with an empty name and be a nullptr.Update the CUDA implementation to handle this.
Motivation and Context
#22035