Add support for ai.onnx.ml.TreeEnsemble.v5 #21851
Open
+833
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbourjau
reviewed
Aug 26, 2024
Co-authored-by: Christian Bourjau <[email protected]>
|
@xadupre could you maybe take a look at this? |
xadupre
reviewed
Sep 17, 2024
xadupre
reviewed
Sep 17, 2024
xadupre
reviewed
Sep 17, 2024
|
Can you look into the failing build? The compilation fails on Windows because a warning is treated as an error (usually an implicit cast to change into a static_cast<...>(...). |
xadupre
approved these changes
Sep 20, 2024
|
/azp run inux CPU CI Pipeline,Windows CPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the TreeEnsemble operator added in version 5 of the
ai.onnx.mlopset. The solution maps the values of the attributes of the v5 operator into attributes of the already supported version 3. Whereas, themembership_valuesare unrolled into chains ofBRANCH_EQnodes.Note that the changes made in #21222 may roll up these
BRANCH_EQchains into a single node again to retain efficient support for categorical features.Ultimately, it may be desirable to have an implementation that directly uses the v5 attributes. However, mapping the v5 attributes into the v3 layout appears to be an easier first step to gaining initial support for the v5 operator.
Motivation and Context
Solves onnx/onnx#5874.