A bag of small random fixes #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
older versions of `mypy` complain about this, but interestingly enough not newer ones... Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
Since `COMPU-PHYS-TO-INTERNAL` and `COMPU-INTERNAL-TO-PHYS` are conceptually inverse functions of each other, the set objects which they are mapping to each other are swapped. i.e., the "source" type of `COMPU-PHYS-TO-INTERNAL` is the physical type of the compu method while `COMPU-INTERNAL-TO-PHYS` it is the opposite. Let's avoid this confusion and use the proper mathematical terms 'domain' (for the set of objects which a function maps from) and 'range' (for the set of objects which a function maps to). Note that the domain and the range are swapped for `COMPU-PHYS-TO-INTERNAL` and `COMPU-INTERNALTO-PHYS`. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
if a text identifier is specified, the jinja keeps a single space before the `TI` attribute, i.e., the output data stays valid. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
this is not too useful IMO, but the spec says `index.xml` (contained by `.pdx` files) should contain a non-empty `SHORT-NAME` tag... Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
andlaus
force-pushed
the
bag_of_fixes
branch
from
abc3817
to
2c5396a
Compare
kayoub5
reviewed
Sep 9, 2024
| internal_type: DataType | ||
| physical_type: DataType | ||
| domain_type: DataType | ||
| range_type: DataType |
There was a problem hiding this comment.
document the properties, or their meaning gets lost in the commit message
There was a problem hiding this comment.
good point. fixed, thanks: 1f39cf9
as usual, thanks [at]kayoub5! Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a set of fixes for a few random annoying issues which I've recently encountered. I decided that they are big enough to warrant a separate PR instead of doing them as "drive bys" for other pull requests.
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information