make the parameters data classes #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
kayoub5
reviewed
Aug 10, 2023
kayoub5
reviewed
Aug 10, 2023
kayoub5
reviewed
Aug 10, 2023
kayoub5
reviewed
Aug 10, 2023
|
If using dataclass, then the custom |
kayoub5
reviewed
Aug 10, 2023
kayoub5
reviewed
Aug 10, 2023
this makes the value of the `.parameter_type` property less "magical". thanks to [at]kayoub5 for proposing this. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
- in non-strict mode, `odxraise()` now logs a warning if an error message was given instead of doing nothing. - we do no longer mess around with the configuration of the `warnings` module. (this was missed during the recent big refactoring of the error handling code.) - if we encounter a ParameterWithDop without a reference to a DOP, we now use the standard exception handling mechanism (`odxassert`), instead of just logging a warning. thanks to [at]kayoub5 for inspiring this. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
since these are now data classes, these methods are automatically generated and the manual variants are thus no longer necessary. Since the these auto-generated methods are more comprehensive than the manual ones, this implied a few minor correction in the writing code and the unit tests to keep my personal test script working. thanks to [at]kayoub5 for noticing this. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
good point. done: 202f766 |
kayoub5
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of the "use
@dataclasswhere appropriate" quest...Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information