Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slightly refactor the length key code #161

Merged
merged 2 commits into from
Jul 17, 2023
Merged

slightly refactor the length key code #161

merged 2 commits into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. refactor the length key code 

    now, instead of using hacks with ODXLINK IDs, proper references to
`LengthKeyParameter` are used by `ParamLengthInfoType`. This
necessitates to include the diag coded types in the reference
resolution machinery because `ParamLengthInfoType` is a diag coded
type and it needs to resolve the reference to the length key
parameter.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
    @andlaus
    andlaus committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5035665 View commit details
    Browse the repository at this point in the history

  2. take review comments into consideration 

    The praise goes to [at]kayoub5, all remaining bugs are my own fault!

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
    @andlaus
    andlaus committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    40dfba6 View commit details
    Browse the repository at this point in the history