Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug #152 #155

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix the bug #152 #155

merged 1 commit into from
Jul 7, 2023

Conversation

zzpbuaa
Copy link
Contributor

@zzpbuaa zzpbuaa commented Jul 5, 2023

When load pdx file it says some structure is missing. Here may be a typo to assign dop to structure.

odxtools/endofpdufield.py Outdated Show resolved Hide resolved
@andlaus
Copy link
Collaborator

andlaus commented Jul 5, 2023

Thanks for the contribution! The patch is good, but before I can merge it you need to sign the CLA. When sending the email, please add me to the CC ([email protected])

@andlaus
Copy link
Collaborator

andlaus commented Jul 5, 2023

(for MIT licensed projects like odxtools, the purpose of the CLA boils down to you certifying that you created your contributions yourself...)

@andlaus
Copy link
Collaborator

andlaus commented Jul 6, 2023

@zzpbuaa: what's the status here? I'd like to get this bug fixed soonish...

@zzpbuaa
Copy link
Contributor Author

zzpbuaa commented Jul 7, 2023

[email protected]

Sorry for the late reply because I'm so busy these days. I just sent out the CLA. You can check if you received it.

@andlaus
Copy link
Collaborator

andlaus commented Jul 7, 2023

cool! thanks a lot for your contribution. merging.

@andlaus andlaus merged commit b472400 into mercedes-benz:main Jul 7, 2023
6 checks passed
@zzpbuaa zzpbuaa deleted the Fix-152 branch July 7, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants