Change logging library to be consistent with FCM relay (and fix log levels) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh interesting, looks like it does a lot of the same stuff. Let me put a pin in that, it would be nice to use a logging library that isn't an external dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs for this module are a little messy, and datadog has trouble parsing them. This uses the same library as the FCM relay does for logging, which has better support for adding fields to log messages, and setting the level of each log message in a way that things like datadog can pick them up.
Tested this locally to a certain extent, and it runs no problem. I didn't go as far as testing notifications, but since the only thing changes was logging, no functionality should be impacted, and logging messages seem to work.