Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add number-ticker to accept decimal places #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snggh
Copy link

@snggh snggh commented Sep 11, 2024

Update number-ticker component by allowing it to accept and display decimal places. This feature will provide more flexibility in presenting non-integer numbers within the ticker component.

Changes:

  • Updated the number-ticker to handle decimal places input by adding decimalPlaces props.
  • Added number-ticker-decimal-demo basic showcase.
  • Update number-ticker.mdx docs.
magicui-number-ticker-decimal.webm

Copy link

vercel bot commented Sep 11, 2024

@snggh is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@itsarghyadas
Copy link
Collaborator

Nice, I will take a look and review it.

Copy link
Collaborator

@itsarghyadas itsarghyadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the delay prop in the mdx file. And nice job on the decimalPlaces prop.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants