Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split button in order view page #39078

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

SerhiiMandrykin
Copy link

@SerhiiMandrykin SerhiiMandrykin commented Aug 21, 2024

Description (*)

This PR adds a fix for split buttons used in layout admin-2columns-left.xml
The bug was added by 6ed18327 so this is a rollback of changes.
Admin Panel is not for mobile so no need to add any changes to fix issues on mobile/tablet.
Here is the video of the issue:

2024-08-21.13.33.21.mov

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Create a custom split button on order view page.
  2. Go to Frontend and place an order
  3. Go to Admin Panel -> Sales -> Orders
  4. Go to the order view page.

Questions or comments

None

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix split button in order view page #39080: Fix split button in order view page

Copy link

m2-assistant bot commented Aug 21, 2024

Hi @SerhiiMandrykin. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@SerhiiMandrykin
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 21, 2024
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Aug 22, 2024

@engcom-Hotel, could you please share what is the issue was fixed in ACP2E-2083? Just to make sure we're not doing any regression in this Pull Request

@engcom-Hotel
Copy link
Contributor

Hello @ihor-sviziev,

JIRA ACP2E-2083 contains the fix for the "Login as customer" button in the admin panel when accessing it via tab/phone.

Before fix it looks something like this:

image

Thanks

@ihor-sviziev
Copy link
Contributor

So, the scrolling has to be only horizontal, right?

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024
@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Sep 13, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

Hello @SerhiiMandrykin,

Looks like the issue is fixed on the latest 2.4-develop branch, could you please check on your end and let us know if the issue still persist.
Till then moving this to on hold.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: On Hold
Development

Successfully merging this pull request may close these issues.

[Issue] Fix split button in order view page
5 participants