Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization key to placeholder #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Muhammadbarznji
Copy link

Overview

This PR adds additional snapshot tests for the ResponsiveTextField component and includes tests for Arabic localization. These changes address issue #11 and enhance our test coverage by ensuring the component behaves correctly under various configurations and locales.

Changes

Tests Added

  • testTextFieldInArabic: Checks the text field in the Arabic locale, both empty and with text.
  • testTextFieldWithDifferentConfigurations: Checks the text field with different configurations (empty, no autocorrect, no autocapitalization).

Related Issue

This PR addresses issue #11.

Screenshots

swift-responsive-textfield.mp4

Checklist

  • Added snapshot tests for ResponsiveTextField.
  • Included Arabic localization tests.

Please review the changes and provide feedback. Thank you!

@Muhammadbarznji
Copy link
Author

Hi @lukeredpath ,
I’ve added a new feature to the swift-responsive-textfield package, but I’m running into an issue with the GitHub CI action related to Code Climate. The error message is:
The process '/Users/runner/work/swift-responsive-textfield/swift-responsive-textfield/cc-reporter' failed with exit code 255
Any ideas on how to resolve this?

@lukeredpath
Copy link
Owner

@Muhammadbarznji thanks for the PR - I will take a look. Don't worry about the CodeClimate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants