Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added value to suppress creation of ClusterRole and ClusterRole… #1558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

db3f
Copy link

@db3f db3f commented Feb 26, 2024

We have users using vCluster who experience problems when trying to uses certain features implying the creation au a ClusterRole/ClusterRoleBinding, since those users don't habe enough rights to do this. Our solution is to provide them with a Service account that has all RBAC rights needed to run vCluster. However, the vCluster helm chart wants to create a ClusterRole, ClusterRoleBinding anyhow. Therefore I added a "flag" suppressClusterRoleCreation to values.yaml to prevent the ClusterRole/ClusterRoleBinding from being created. If this flag is not set or set to false, CLusterRole creation will happen as before.

What issue type does this pull request address?

What does this pull request do? Which issues does it resolve?
Gives the option to suppress ClusterRole cration.

Please provide a short message that should be published in the vcluster release notes
Added a flag to values.yaml to optionally prevent the Creation auf a ClusterRole

…Bindung. If the value is not set, cluster roles will be created as before
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit fd96b24
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/65dc68103f139c0008ac2641

@FabianKramm
Copy link
Member

Hey @db3f ! Thanks for creating this PR, we are currently in the process of refactoring the helm values and this will be addressed as part of that refactoring with version v0.20.0, so I'll leave this open for now.

@mavogel
Copy link

mavogel commented Jul 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants