Add a file extension to download url #2314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
approved these changes
Sep 18, 2024
| base, | ||
| asset.playbackId, | ||
| source.path, | ||
| "download." + formatToFileExtension.get(asset.videoSpec.format), |
There was a problem hiding this comment.
wdyt of naming the file with the asset name instead?
Suggested change
| "download." + formatToFileExtension.get(asset.videoSpec.format), | |
| encodeURIComponent(`${asset.name}.${formatToFileExtension.get(asset.videoSpec.format)}`), |
There was a problem hiding this comment.
Only issue with that is that the name for direct uploads will contain the original file extension and so they'll end up with double file extensions :(
There was a problem hiding this comment.
could just strip anything after the final .?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on a CDN rule to re-route the request to the standard
/videopath. I'll probably put it behind an experiment to begin with and also probably should have the mapping of format to file extension in catalyst.What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist