Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard base #51

Merged
merged 17 commits into from
Jan 23, 2023
Merged

Standard base #51

merged 17 commits into from
Jan 23, 2023

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Oct 18, 2021

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

1 similar comment
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@nemchik nemchik added work-in-progress Stale exempt and removed no-pr-activity labels Apr 13, 2022
@nemchik nemchik force-pushed the standard-base branch 4 times, most recently from 966cc95 to 8cc4957 Compare August 16, 2022 00:28
@nemchik
Copy link
Member Author

nemchik commented Oct 5, 2022

Screenshot looks strange. It should be showing the app, not the default index.

edit: it was cached, it's fine now

@nemchik nemchik marked this pull request as ready for review October 5, 2022 13:42
@aptalca aptalca mentioned this pull request Oct 25, 2022
1 task
@nemchik
Copy link
Member Author

nemchik commented Oct 29, 2022

@technofreak74 can you test lspipepr/lychee:v4.6.1-pkg-61a4e78d-pr-51 ?

@technofreak74
Copy link
Contributor

I don't know how to test the unraid template but running lspipepr/lychee:v4.6.1-pkg-61a4e78d-pr-51 via docker compose (on a fresh ubuntu VM) works? I've only just started using lychee though so I'm not sure how conclusive my 'works' is 😄

@TechGeeksIO
Copy link

TechGeeksIO commented Jan 6, 2023

I've tested lspipepr/lychee:v4.6.1-pkg-61a4e78d-pr-51 and it seems to work fine if you install a fresh container, if I try to upgrade my old container with the current version (master branch) I get the following error message:

grafik

Edit: sounds like I have the same issue like him and this is related to my nginx reverse proxy
LycheeOrg/Lychee-Docker#133

@thespad
Copy link
Member

thespad commented Jan 6, 2023

I've tested lspipepr/lychee:v4.6.1-pkg-61a4e78d-pr-51 and it seems to work fine if you install a fresh container, if I try to upgrade my old container with the current version (master branch) I get the following error message:

grafik

Edit: sounds like I have the same issue like him and this is related to my nginx reverse proxy LycheeOrg/Lychee-Docker#133

Check your container logs with the upgrade and see what it mentions about outdated confs - you probably just need to remove the old ones and let them get re-copied.

@anthonyrussano
Copy link

I have setup a clean install and an upgrade environment to test.

Everything seems to work fine in both enviroments, except for the sharing button.
When I click the share button for an individual photo, nothing happens.
I will try to perform some additional debugging.

@anthonyrussano
Copy link

I think this share button issue might be related to the BadRequestHeaderException

LycheeOrg/Lychee-Docker#133

image

@nemchik nemchik requested a review from a team January 22, 2023 20:49
@nemchik nemchik merged commit a5d7e4e into master Jan 23, 2023
@nemchik nemchik deleted the standard-base branch January 23, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale exempt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants