fix(findRelationshipsV2): change source/dest params from Urn to String #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybz1013
reviewed
Sep 13, 2024
| @@ -526,7 +526,7 @@ OwnedBy.class, new LocalRelationshipFilter().setCriteria(new LocalRelationshipCr | |||
| LocalRelationshipFilter filterUrn2 = new LocalRelationshipFilter().setCriteria(new LocalRelationshipCriterionArray(filterUrnCriterion2)); | |||
|
|
|||
| // test owned by of crew2 can be found | |||
| List<OwnedBy> ownedByCrew2 = _localRelationshipQueryDAO.findRelationshipsV2(null, null, crewEntityUrn, filterUrn2, | |||
| List<OwnedBy> ownedByCrew2 = _localRelationshipQueryDAO.findRelationshipsV2(null, null, "crew", filterUrn2, | |||
There was a problem hiding this comment.
for the 3rd arg, are we passing in crew or leave it null?
If it doesn't change the implementation, can we leave it null? So in global API I wont have to extract it from urn. Thanks
There was a problem hiding this comment.
The previous filter validation logic stated that "if entity urn is null, the filter must also be null. We should continue to enforce this for the case where the asset is a registered MG asset type.
So in the GQS, we need to pass in any non-null and non-empty string as this param if we want the query to find non-MG asset types.
jsdonn
force-pushed
the
findRelationships
branch
from
92bd49c
to
c6fb3dd
Compare
ybz1013
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are cases when a user doesn't need to provide an urn for the destination. For example, they only specify the destination type (like "dataset") but without also providing a filter on the UrnField (like urn = "urn:li:dataset:foo"). The current implementation does not support this as it expects either an Urn or null for the source and destination entities. If null, there's no way to tell the API which type of destination to look for.
Testing Done
adjusted unit tests. ./gradlew build
Checklist