[Coral-Trino] Migrate UNNEST From RelToTrinoConverter to SqlCallConverter layer #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiqiangin
approved these changes
Jun 22, 2023
coral-trino/src/main/java/com/linkedin/coral/trino/rel2trino/CoralToTrinoSqlCallConverter.java
Show resolved
Hide resolved
|
|
||
| // Transform UNNEST(fieldName) to UNNEST(TRANSFORM(fieldName, x -> ROW(x))) | ||
| if (operator.getRelDataType() != null) { | ||
| String fieldName = "empty"; |
There was a problem hiding this comment.
Why is the initial value of fieldName is "empty"
There was a problem hiding this comment.
Modified it to String fieldName = unnestOperand.toSqlString(TrinoSqlDialect.INSTANCE).getSql();
Probably the if - else if section below it can be removed but I'll get to that in a follow-up PR after i-testing again. Thanks for bringing it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Prior to this PR, transformations related to the
UNNEST()function were applied inRelToTrinoConverterfor translations from Coral IR -> Trino SQL.In an attempt to standardize Coral intermediate representation and converge
RelToTrinoConverterwithCoralRelToSqlNodeConverter, the related transformations are extracted out asSqlCallTransformersover 3 transformations:JoinSqlCallTransformer,AsOperatorTransformerandUnnestOperatorTransformer. Also, the corresponding code fromCoralRelToSqlNodeConverteris copied over toRelToTrinoConverter. In a separate PR,RelToTrinoConverterwill be removed.Other changes:
(1) Unused config
SUPPORT_LEGACY_UNNEST_ARRAY_OF_STRUCThas been deleted and the corresponding unit tests,testLegacyOuterUnnestArrayOfStructandtestLegacyUnnestArrayOfStructfromHiveToTrinoConverterTesthave been removed.(2) Several unit tests in
TrinoToRelConverterTesthave been marked as unsupported as their SqlNode representations do not align with Coral IR at present.Most of the code changes are part of the previous effort of extracting UNNEST operator in PR #315 .
How was this patch tested?
./gradlew spotlessApply
./gradlew build
modified UTs
i-tested with production views