Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders don't have a "deactivated" status. #301

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Feb 24, 2020

Use "invalid" instead, and add comments linking to the spec.

Fixes #300

Use "invalid" instead, and add comments linking to the spec.
@cpu
Copy link
Contributor

cpu commented Feb 25, 2020

👋 FWIW Boulder has the same divergence: https://github.com/letsencrypt/boulder/blob/9a86abc1550425a73f912c25a11c29160f58a85a/sa/sa.go#L1218-L1221

@jvanasco
Copy link
Contributor

I think I managed to still trigger this. I need to do a few more tests to make sure i'm running the right code - I'm not very good with go

@jsha
Copy link
Contributor Author

jsha commented Feb 27, 2020

Ok, thanks so much for testing! If you need any help, let me know.

Zola-github
Zola-github previously approved these changes Feb 28, 2020
@jvanasco
Copy link
Contributor

I finally got a chance to test. This works as expected from the RFC.

core/types.go Outdated Show resolved Hide resolved
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment nits.

core/types.go Outdated Show resolved Hide resolved
Co-authored-by: Samantha <[email protected]>
@beautifulentropy beautifulentropy self-requested a review May 10, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong implementation of ACME spec: Orders should transition to "invalid", not "deactivated"
6 participants