Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CSRs whose CN is longer than acceptable #7700

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Conversation

jprenken
Copy link
Contributor

@jprenken jprenken commented Sep 6, 2024

Also rework comments & test names for clarity, add tests for this new CN handling, and change/remove tests that should indeed no longer fail.

Fixes #7623

@jprenken jprenken requested a review from a team as a code owner September 6, 2024 00:07
aarongable
aarongable previously approved these changes Sep 6, 2024
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit and one request

ca/ca_test.go Show resolved Hide resolved
csr/csr_test.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy merged commit 412e959 into main Sep 10, 2024
19 checks passed
@beautifulentropy beautifulentropy deleted the looong-cn branch September 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow CSRs whose CN is longer than acceptable
3 participants