Patch 32 #309
Closed
Patch 32 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove pele from window_new (unused input argument); pele is already applied earlier in gnssir_guts_v2, prior to arc splitting.
remove pele from window_new (unused input argument)
|
this was a really good PR - but unfortunately there were a lot of conflicts because i had been working on the master version of the code and trying to figure out how to accommodate the request to have different pele inputs for different elevation angle pairs. i kept your ideas - and the new versions should no longer send pele to the windowing function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove pele from window_new (unused input argument), both in gnssir_guts_v2 and in ql.