Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelizing gnssir #259

Merged
merged 22 commits into from
Mar 15, 2024
Merged

Conversation

aaryan-rampal
Copy link
Contributor

Added force flags to gzip currently

Followup from #245 (comment)

aaryan-rampal and others added 22 commits February 22, 2024 18:10
Have not added docstrings and comments yet, waiting for approval of
concept
Not running still from command line though. hmm
I believe when I used gnssrefl.rinex2snr import, it used the default
library which I had downloaded using pip which did not expect the
par argument. When I load the local file manually, it seems to work
fine. I don't know what a more appropriate fix for this is.
TODO: what is year_st in gnssir_cl.py?
Otherwise runtime exceptions occur
I think my gnssrefl is not being updated, so gnssrefl.gps and
gnssrefl.gnssir_v2 don't have the newest methods. I am undoing these
changes because it should work on an updated copy
@kristinemlarson kristinemlarson merged commit 9b2ee4e into kristinemlarson:master Mar 15, 2024
1 check passed
@kristinemlarson
Copy link
Owner

@aaryan-rampal

i don't use the docker - but i thought i should check to see how the new gnssir code performs with -par 10.
and it isn't nearly as useful as running it on my macOS. so that is something that should be looked into.
presumably there is some setting in the Dockerfile to tell it to use more processors. it isn't a matter of the python code - cause that is working. @timdittmann may want to enter the discussion.

@kristinemlarson
Copy link
Owner

kristinemlarson commented Mar 15, 2024

there are problems when the code tries to create files/directories at the same time. these are common files - not date specific files. i will see if i can fix it. not seeing this on my mac - only in the docker. as far as the cpu thing goes, it appears that you can set that when you run the docker.

@timdittmann
Copy link
Collaborator

@aaryan-rampal

i don't use the docker - but i thought i should check to see how the new gnssir code performs with -par 10. and it isn't nearly as useful as running it on my macOS. so that is something that should be looked into. presumably there is some setting in the Dockerfile to tell it to use more processors. it isn't a matter of the python code - cause that is working. @timdittmann may want to enter the discussion.

Hi @kristinemlarson @aaryan-rampal -- it is so cool to see this collaborative open source development. 🚀

As far as performance when using Docker, depending on how you have your docker desktop configured, you might not have access to the same number of cores at runtime in the docker? This is configurable.

Either in addition to or in place of explicit parallelism (par), what do you think about experimenting with gnssir performance when letting the os determine the number of processes? E.g. the default for multiprocessing is to spawn os.cpu_count() processes.

@kristinemlarson
Copy link
Owner

kristinemlarson commented Mar 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants