Skip to content

Commit

Permalink
Hide frontpage channel descriptions (#100)
Browse files Browse the repository at this point in the history
* Prettier changes (NFC)

* Change: hide frontpage channel descriptions

* Discussion here: https://koodiklinikka.slack.com/archives/C6P893LFK/p1677587646981509
* tl;dr: Hiding the channel topics as those cannot really be controlled or made sure to be representative on the website
* Change the stylings to accommodate this
* Note that it seems to me at least that the channels are fetched and populated during build time, not in runtime, and thus the data is effectively stale (more in the linked thread), and this does nothing to fix that
  • Loading branch information
anttispitkanen committed Mar 1, 2023
1 parent a00450d commit 2791108
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 31 deletions.
12 changes: 2 additions & 10 deletions pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,10 @@ const IndexContent = (props: IndexProps) => (
#{channel.name}
</a>
</div>
<span className="channel-members">
{channel.num_members} jäsentä
</span>
</td>
<td>
<span>
<ReactMarkdown
className="channel-topic"
components={{ p: ChannelReferenceRenderer }}
>
{channel.topic}
</ReactMarkdown>
<span className="channel-members">
{channel.num_members} jäsentä
</span>
</td>
</tr>
Expand Down
6 changes: 3 additions & 3 deletions styles/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,8 @@ footer {
}
.social {
height: 30px;
margin-left: .5em;
margin-right: .5em;
margin-left: 0.5em;
margin-right: 0.5em;
}
.feed {
width: $feedWidth;
Expand Down Expand Up @@ -533,7 +533,6 @@ footer {
}
}
.channels {
width: 100%;
list-style: none;
padding: 0;
td {
Expand Down Expand Up @@ -583,6 +582,7 @@ footer {
}
.channel-members {
font-size: 12px;
margin-left: 1rem;
}
.channel-topic {
p {
Expand Down
22 changes: 4 additions & 18 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
{
"compilerOptions": {
"target": "es5",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": true,
"skipLibCheck": true,
"strict": false,
Expand All @@ -19,17 +15,7 @@
"jsx": "preserve",
"incremental": true
},
"typeRoots": [
"./node_modules/@types",
"./typings"
],
"exclude": [
"node_modules"
],
"include": [
"next-env.d.ts",
"**/*.ts",
"**/*.tsx",
"./typings/*"
]
"typeRoots": ["./node_modules/@types", "./typings"],
"exclude": ["node_modules"],
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", "./typings/*"]
}

0 comments on commit 2791108

Please sign in to comment.