feat: support extraEnv Variables

knechtionscoding · Apr 6, 2023 · 617e058 · 617e058
1 parent 4b059ff
commit 617e058
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 4 deletions.
diff --git a/charts/ecr-cleanup/Chart.yaml b/charts/ecr-cleanup/Chart.yaml
@@ -20,10 +20,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.10
+version: 0.3.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.2.10"
+appVersion: "0.3.0"
diff --git a/charts/ecr-cleanup/README.md b/charts/ecr-cleanup/README.md
@@ -6,7 +6,7 @@ Deploys a job that cleans up an ECR repo based on the following rules.
 3. Has the container been tagged with the word `keep`
 4. Is the container the only tag in the ECR repository
 
-![Version: 0.2.10](https://img.shields.io/badge/Version-0.2.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.10](https://img.shields.io/badge/AppVersion-0.2.10-informational?style=flat-square)
+![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.3.0](https://img.shields.io/badge/AppVersion-0.3.0-informational?style=flat-square)
 
 ## Values
 
@@ -15,6 +15,7 @@ Deploys a job that cleans up an ECR repo based on the following rules.
 | awsRegistryId | string | `""` | ECR Registry ID to override picking the default |
 | command | list | `["/code/main.py"]` | Command being run by the cronjob |
 | dryRun | bool | `false` | Should the tool run in dryrun |
+| extraEnvs | object | `{}` |  |
 | fullnameOverride | string | `""` | Override fullname |
 | image.pullPolicy | string | `"IfNotPresent"` | Pull Policy for images in cronjob |
 | image.registry | string | `"ghcr.io"` | Image Registry |

diff --git a/charts/ecr-cleanup/templates/cronjob.yaml b/charts/ecr-cleanup/templates/cronjob.yaml
@@ -37,7 +37,9 @@ spec:
                 - name: DRY_RUN
                   value: "{{ .Values.dryRun }}"
                 {{- end }}
-
+                {{- with .Values.extraEnvs }}
+                {{- . | toYaml | nindent 16 }}
+                {{- end }}
               command: {{ .Values.command }}
               securityContext:
                 {{- toYaml .Values.securityContext | nindent 16 }}

diff --git a/charts/ecr-cleanup/values.schema.json b/charts/ecr-cleanup/values.schema.json
@@ -14,6 +14,12 @@
         "dryRun": {
             "type": "boolean"
         },
+        "extraEnvs": {
+            "type": [
+                "object",
+                "null"
+            ]
+        },
         "image": {
             "type": "object",
             "properties": {

diff --git a/charts/ecr-cleanup/values.yaml b/charts/ecr-cleanup/values.yaml
@@ -73,3 +73,6 @@ resources:
   # requests:
   #   cpu: 100m
   #   memory: 128Mi
+
+## -- ENV variables to pass to cronjob
+extraEnvs: {}