Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track clients & operations filters using search params #5616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidguilherme
Copy link

Background

At Toast, every team has a weekly metric review meeting where teams go through their dashboards and metrics for their services and SPAs. Teams have been using Hive Insights for client metrics. As teams go through a spreadsheet with all dashboard links, it has been a bit annoying to have to set the filters every time.

This PR adds the clients and operations filters to the search params (same done already for the date presets).

Description

  • Created a hook to manage any search params filter.
  • Changed clients and operations filters to use useSearchParamsFilter instead of useState.
  • Fixed useDateRangeController to not remove current search params when the user changes it.
  • Changed Fallback component to display a more generic message as there might not be stats for a given combination of filters (clients, operations, date).
  • Changed clients and operations triggers so it ignores values that are not present in the backend response.
  • Added a new util helper to pick partial objects from a set of keys

Checklist

  • Input validation
    • I tested with a couple inputs (invalid ones, with special characters, long strings). Same as below. Should I truncate the list?
  • Memory management
    • Should we truncate to specific size for clients and operations filter?

Copy link

changeset-bot bot commented Sep 22, 2024

⚠️ No Changeset found

Latest commit: 9f7b4d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant