[in-progress, do-not-merge] upgrade docker build and github pipeline #4935
+29
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Sep 11, 2024
.github/workflows/docker-images.yml
Outdated
| # pull_request: #for debugging purposes | ||
| # branches: [ "master" ] | ||
| pull_request: #for debugging purposes | ||
| branches: [ "master" ] |
There was a problem hiding this comment.
I suggest that you add
https://github.com/k2-fsa/icefall/blob/master/.github/workflows/build-cpu-docker.yml#L3
After merging it into the master, you will see something like below:
You can trigger the actions manually by clicking, without pushing anything to github.
|
thanks!
y.
…On Wed, Sep 11, 2024 at 11:00 AM Fangjun Kuang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/docker-images.yml
<#4935 (comment)>:
> @@ -14,8 +14,8 @@ on:
- info
- warning
- debug
-# pull_request: #for debugging purposes
-# branches: [ "master" ]
+ pull_request: #for debugging purposes
+ branches: [ "master" ]
I suggest that you add
https://github.com/k2-fsa/icefall/blob/master/.github/workflows/build-cpu-docker.yml#L3
After merging it into the master, you will see something below:
Screenshot.2024-09-11.at.16.58.26.png (view on web)
<https://github.com/user-attachments/assets/64381af2-b0c4-472a-a69d-29f539b29df0>
You can trigger the actions manually by clicking, without pushing anything
to github.
—
Reply to this email directly, view it on GitHub
<#4935 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUKYX4F5YN6S424F7CDTNLZWABBPAVCNFSM6AAAAABOAO5YFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJWGEZDSNJYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will take some time, lots of problems