Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMI hotfix #4739

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

AMI hotfix #4739

wants to merge 12 commits into from

Conversation

athornton1618
Copy link

There's a couple issues with egs/ami (broken URLs, missing call to generate x-vector, etc). As part of a class at Columbia University, I worked out of that directory and cleaned up some of those dependencies. The corrections should become part of egs/ami for posterity.

Copy link
Contributor

@danpovey danpovey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Is the dir egs/ami/s5c_apt2141 supposed to be added? I would have thought you'd submit just your fixes? There are things like MANIFEST.txt that don't look like they should be added, too..

@athornton1618
Copy link
Author

Oops! Yup, I meant to only push a subset of the changes here. (It was packaged in this state for the course I did this project for). Let's delete this PR and I'll make a new one later this week with just the relevant fixes.

@jtrmal
Copy link
Contributor

jtrmal commented May 9, 2022 via email

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

@stale stale bot added the stale Stale bot on the loose label Jul 10, 2022
@kkm000 kkm000 added in progress Issue has been taken and is being worked on stale-exclude Stale bot ignore this issue and removed stale Stale bot on the loose labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Issue has been taken and is being worked on stale-exclude Stale bot ignore this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants