Update mathjax.html #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the path on line 3 for this script should be from the directory root rather than `/just-the-docs-tests`: From this: `src="/just-the-docs-tests/assets/js/mathjax-script-type.js">` To this: `src="/assets/js/mathjax-script-type.js">`. The former version will still work when not required but causes this error message: ERROR `/just-the-docs-tests/assets/js/mathjax-script-type.js' not found.
|
@DylanLawless Thanks for submitting a PR for this repo. When I make the proposed update to line 3 and build the site locally, I get: I think line 3 should instead be replaced by: If you agree, please update the PR accordingly, and check that the MathJax test pages are error-free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the path on line 3 for this script should be from the directory root rather than
/just-the-docs-tests:From this:
src="/just-the-docs-tests/assets/js/mathjax-script-type.js">To this:
src="/assets/js/mathjax-script-type.js">.The former version will still work when not required but causes this error message: ERROR `/just-the-docs-tests/assets/js/mathjax-script-type.js' not found.