Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event alias #138

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Event alias #138

wants to merge 4 commits into from

Conversation

arschmitz
Copy link
Member

This PR removes all dependency on the jQuery Core event/alias module and deprecated module

It also updates the jQuery core dependency to be >= 1.7.0 to allow this removal.

Browserify build was not working when tested with current browserify updated example to work again and update to use jQuery proper jquery-browserify has not been updated in 3 years.

@@ -22,6 +22,6 @@
"homepage": "https://github.com/brandonaaron/jquery-mousewheel",
"download": "https://github.com/brandonaaron/jquery-mousewheel/tags",
"dependencies": {
"jquery": ">=1.2.2"
"jquery": ">=1.7.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove this file since we have no plans to resurrect our plugins repo in its current form?

@@ -12,6 +12,6 @@
"test"
],
"dependencies": {
"jquery": ">=1.2.2"
"jquery": ">=1.7.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, drop the obsolete version from bower.json

@jzaefferer
Copy link
Member

Looks good to me

@arschmitz
Copy link
Member Author

@jzaefferer added removal of that property

@jzaefferer
Copy link
Member

👍

@dmethvin
Copy link
Member

I'm okay with this change but should we consider it a major break? Bower and npm users should be protected by the dependencies declared in their files but the majority of users are probably just including the file and putting this out as e.g. 3.1.14 may not make things clear.

@arschmitz
Copy link
Member Author

@dmethvin thats probably a good point we should probably do a full version bump

@jzaefferer
Copy link
Member

The readme in test/browserify still says "npm install jquery-browserify", the rest looks wrong, too. Shouldn't it describe how to install browserify?

@dmethvin
Copy link
Member

dmethvin commented Aug 5, 2015

@jzaefferer I opened #150 for that.

Base automatically changed from master to main March 16, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants