Set blurred background from external api #15131
Open
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
damencho
requested changes
Sep 17, 2024
I don't need it at the moment but it could be an interesting feature. I'll add it when moving the code into virtual-background |
Razor1700
force-pushed
the
feature-request/set-blurred-background-from-external-api
branch
from
a1803c3
to
9aa4e65
Compare
Add setBlurredBackground command to external api.
Razor1700
force-pushed
the
feature-request/set-blurred-background-from-external-api
branch
from
9aa4e65
to
8c8573c
Compare
|
Parameter to choose blur type added to the method |
damencho
requested changes
Sep 19, 2024
| const tracks = APP.store.getState()['features/base/tracks']; | ||
| const videoTrack = getLocalVideoTrack(tracks)?.jitsiTrack; | ||
| const muted = this.isLocalVideoMuted(); | ||
|
|
There was a problem hiding this comment.
You can move this in toggleBlurredBackgroundEffect and dispatch it directly in API.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setBlurredBackground command to external api